Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move product roles to the handbook #1376

Merged
merged 6 commits into from
Aug 13, 2020
Merged

Move product roles to the handbook #1376

merged 6 commits into from
Aug 13, 2020

Conversation

sqs
Copy link
Member

@sqs sqs commented Aug 7, 2020

I was reviewing the Technical Writer job description and was going to add it to the handbook's marketing section, but based on our recent conversations, it will live in the product team. So I prototyped what it would look like for roles to live in the handbook.

TODO:

  • Move full job descriptions for other roles from the careers repo to the handbook
  • Review/revise technical writer job description

@sqs sqs requested a review from christinaforney as a code owner August 7, 2020 02:53
@christinaforney
Copy link
Contributor

👍 This is the first step in migrating the careers page into the handbook, correct? This PR loses the responsibilities we added for the technical writer role / developer communications (do you have thoughts on the difference?). Would you want those to live elsewhere or are you planning on merging them into the job description here?

How will this work when a role is no longer open for applicants? What will the difference be between a role on the team vs. a role that is open for hiring? How will we make sure this is clear?

sqs and others added 3 commits August 12, 2020 15:40
I was reviewing the Technical Writer job description and was going to add it to the handbook's marketing section, but based on our recent conversations, it will live in the product team. So I prototyped what it would look like for roles to live in the handbook.

TODO:

- Move full job descriptions for other roles from the careers repo to the handbook
- Review/revise technical writer job description
@christinaforney
Copy link
Contributor

This concludes moving all the product roles to the handbook (PM, Design, Technical writer). Corresponding PR for careers repo here: sourcegraph/careers#121


### [Roles and responsibilites](roles.md)
### [Roles](roles/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The roles and hiring sections felt redundant, so I combined them. They still feel a bit redundant to the Members section above, and in order to not have broken links I needed to create the redundant roles/index.md that simply links to the roles pages. If you have ideas how we can clean this up while keeping it top level, I'd love to hear suggestions!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this a little better by linking to the docs areas in the Members section, and am now only linking to the roles pages here. Feedback still appreciated!

@christinaforney
Copy link
Contributor

I'm going to go ahead and merge this, since it's blocking going live with the JD. I would still love feedback and I'll continue to iterate on the job description!

@christinaforney christinaforney merged commit 6d01f71 into master Aug 13, 2020
@christinaforney christinaforney deleted the roles branch August 13, 2020 18:54
kghopson added a commit that referenced this pull request Aug 13, 2020
kghopson pushed a commit that referenced this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants