Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update software-engineer-security.md #113

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Update software-engineer-security.md #113

merged 4 commits into from
Jul 30, 2020

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 28, 2020

Updated the JD. Changed the language to be a bit more security focused, while highlighting that we code.

@chayim chayim requested a review from nicksnyder July 28, 2020 15:56
- Published blog posts and/or tech talks about your work.
- Experience working on high-performing teams, preferably tech startups.
- Experience improving the security posture of a small team, and helping that team carry the baton themselves.
- Experience working in an ops environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to indicate that the ideal security candidate can experience managing infrastructure. Now that I've stepped away from it a better point could be:
Experience managing and securing infrastructure

- Ability to understand, debug, and write Go and TypeScript to fix security issues.
- Ability to secure cloud applications that use our tech stack: Kuberentes, Docker, Google Cloud Platform.
- Ability to secure cloud applications that use our tech stack: Kubernetes, Docker, Google Cloud Platform.
- Ability to define, plan, and prioritize security work that needs to be done (and then go do that work).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of these should actually be moved to responsibilities (my thinking on how to write JDs has changed since I wrote this). For example this line seems to duplicate Identify what our security needs are and develop a roadmap to improve and ensure the security of our product..

@@ -2,28 +2,31 @@

# Software Engineer - Security

We are looking for an engineer who specializes in security to help us proactively secure our product. This includes the security of Sourcegraph Cloud as well as making it easy for our customers to secure their own private Sourcegraph instances that they deploy on-premise. You will be one of the first security hires at Sourcegraph and will have the opportunity to build a world-class security culture and team from the ground up.
We are looking for an engineer who is passionate about security, and wants to proactively secure our product and our customers. You will help our customers secure their on-premise versions of Sourcegraph, and contribute to the security of our product and Sourcegraph cloud. You will be one of the early security hires at Sourcegraph, helping to build a world-class security team, where everyone contributes, from writing code to running vulnerability scans.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit worried that the first two sentences awkwardly have two "ands." Can you think of a way to avoid this without losing the meaning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggled with that - a lot. The best version I hit on is below, but I'd love something more clean. The first sentence is particularly troublesome.

We are looking for an engineer who is passionate about security, wanting to proactively secure our product and our customers. You will help our customers secure their on-premise versions of Sourcegraph, while contributing to the security of our product and Sourcegraph cloud.

@nicksnyder
Copy link
Contributor

nicksnyder commented Jul 30, 2020

I pushed a commit that defers more info to the handbook. What do you think? If you think something is missing around responsibilities or expectations, then let's flesh that out in the handbook.

I also updated the security specific application questions.
Screen Shot 2020-07-30 at 11 26 55 AM

Copy link
Contributor Author

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@chayim chayim merged commit 6e4f00b into master Jul 30, 2020
@chayim chayim deleted the security-jd-change branch July 30, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants