Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible process change on security hire #115

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 4, 2020

The potential process change is highlighted here. I'm thinking that we can ask new hires to explain a vulnerability, in plain English, and assess it's impact. This will allow us to both gauge their understanding of security, and their ability to communicate. To wit, we would be relying on an existing, public vulnerability, already disclosed in the mitre database, and asking for a two to three paragraph response.

@chayim chayim requested a review from nicksnyder as a code owner August 4, 2020 21:36
1. You write your first Sourcegraph [RFC](https://about.sourcegraph.com/handbook/communication/rfcs) by creating a new Google Doc using [this template](https://docs.google.com/document/d/1ol7aVXuXB7XL4DorOoxoDsaSyFI9Pv4Bcc1zfo-iLtw/edit#). We will review your RFC and may ask questions via comments directly on the document.
1. You speak with the Sourcegraph Cloud engineering manager for 1 hour about your RFC.
1. We schedule 4 hours of remote interviews over video chat across multiple days.
1. You write a short security assessment, taking less than **30m** of your time, explaining a security vulnerability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you flesh this out more? Is this a security assessment about Sourcegraph or could it be about a past security threat? Can a candidate share something they have already written?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to dummy up a template, much like the RFC. The idea is that a candidate would explain a vulnerability for which we provide the appropriate research. The candidate will help explain the vulnerability in plain English. Given the information we provide, they would ideally explain the impact of the vulnerability to the Sourcegraph product. I should have it ready tomorrow afternoon.

@nicksnyder
Copy link
Contributor

ping on getting this merged

@chayim chayim requested a review from nicksnyder August 20, 2020 08:24
@chayim
Copy link
Contributor Author

chayim commented Aug 20, 2020 via email

@chayim
Copy link
Contributor Author

chayim commented Aug 20, 2020

ping on getting this merged

Updated with a sample CVE and changed the timeline. I feel like it was unfair to the candidate. Have a look - I'm pro merging, but wanted to run it by you.

1. You write your first Sourcegraph [RFC](https://about.sourcegraph.com/handbook/communication/rfcs) by creating a new Google Doc using [this template](https://docs.google.com/document/d/1ol7aVXuXB7XL4DorOoxoDsaSyFI9Pv4Bcc1zfo-iLtw/edit#). We will review your RFC and may ask questions via comments directly on the document.
1. You speak with the Sourcegraph Cloud engineering manager for 1 hour about your RFC.
1. We schedule 4 hours of remote interviews over video chat across multiple days.
1. You write a short security assessment, taking less than **1hr** of your time, explaining a security vulnerability [sample problem](https://docs.google.com/document/d/1oXhjU_3y2uhpmWJ2hD0NTaqSanUAOlKDFFmjazAU3Rg/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please share this doc with the Sourcegraph org so we can suggest/edit/comment. Can you inline instructions into that document?

@nicksnyder
Copy link
Contributor

Merging since this is an improvement and I want to move this content to the handbook. I still think the project could use clearer instructions and I left a comment in the doc

@nicksnyder nicksnyder merged commit 66b3bde into master Aug 21, 2020
@nicksnyder nicksnyder deleted the ck-processchange branch August 21, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants