fix: use error names, not error codes

[felixfbecker]

Errors in ECMAScript have a message and a name. code is something Node-specific, and those errors still all have name. Native errors like TypeError, URIError, AggregateError (coming soon) all only have name. When we send errors to/from background pages or web workers, we can only reasonably expect name to be present, so we should never rely on code. See e.g. mozilla/webextension-polyfill#210 or comlink source code.

Using both in our codebase inconsistently opens the risk to checking for the wrong property, (especially because errors are any in TypeScript) and adds additional code.

This change removes all uses of code in favor of name. There is still a case for having name be optional (e.g. GraphQL errors don't have a name, but do have message), so ErrorLike is still kept for now but we could think about just using the native Error interface in the future.

[codecov]

Codecov Report

Merging #240 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files          13       13           
  Lines         566      566           
  Branches      141      141           
=======================================
  Hits          481      481           
  Misses         85       85           

Impacted Files	Coverage Δ
src/errors.ts	37.50% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2eb47...046e6fc. Read the comment docs.

[eseliger]

wow what an assertion 😬

[sourcegraph-bot]

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀