Fix: Change initial bookmark icon color to avoid misunderstanding with red theme #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RabbiIslamRony
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user selects red (#ff0000) as the primary theme color, they mistakenly think that the bookmark is already booked due to the color resembling the 'booked' state. To avoid this misunderstanding, we need to change the initial icon color
PR Type
What kind of change does this PR introduce?
Description
How to reproduce the issue or how to test the changes
1.When red is set as the theme color, the single listing page shows the bookmark as already booked, even without clicking the 'booked' button.
before ( without clicked )
https://prnt.sc/ZBSnZNz9L2BN
after ( without clicked)
https://prnt.sc/sELgRXs1U_rs
Any linked issues
Fixes #
Checklist