refactor!: Literal to use sqlparser::ast::Expr
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To simplify the work in this PR, I have merged #451 into this. |
|
Stop spamming my email retarted faggot |
varshith257
force-pushed
the
refactor-literal
branch
from
2963f1a to
39de752
Compare
|
@olusamkell Please unsubscribe notifications from PR if you are receiving them. I don't know what exactly is going on, you may receive my PR notifications in your mail unless you subscribed for all notifications from this repo |
varshith257
force-pushed
the
refactor-literal
branch
from
39de752 to
e04a67b
Compare
* refactor!: `PosqlTimeZone` to use `sqlparser::ast::TimezoneInfo` * feat: add util function for `PoSQLTimeStamp`
varshith257
force-pushed
the
refactor-literal
branch
from
e04a67b to
eda56bd
Compare
This was referenced Jan 13, 2025
4 tasks
|
Waiting for #451 to get merge such that this will unlock and i will cleanup this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.This PR depends on
proof_of_sql_parser::intermediate_ast::PoSQLTimezonewithsqlparser::ast::TimezoneInfoin the proof-of-sql crate #451Rationale for this change
What changes are included in this PR?
Are these changes tested?
Part of #235
Note to me: A few refs of Literal are present in query_context_builder and expression_evaluation.rs and will be fixed them