Open Trash from the application #8613
ci.yml
on: pull_request
TypeScript
1m 38s
ESLint
2m 22s
Cypress
18m 10s
Rust Formatting
56s
Matrix: clippy
Annotations
20 warnings
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L28
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:28:23
|
28 | let mut model_str = first.model.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `first.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L41
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:41:40
|
41 | std::mem::replace(&mut model_str, op.model.clone()),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L54
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:54:40
|
54 | std::mem::replace(&mut model_str, op.model.clone()),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L83
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:83:15
|
83 | ... model: model_str.clone(),
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `model_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
unused `std::result::Result` that must be used:
core/crates/sync/src/ingest.rs#L118
warning: unused `std::result::Result` that must be used
--> core/crates/sync/src/ingest.rs:118:7
|
118 | self.receive_crdt_operation(op).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
118 | let _ = self.receive_crdt_operation(op).await;
| +++++++
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L742
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:742:10
|
742 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
note: the lint level is defined here
--> core/crates/heavy-lifting/src/lib.rs:9:2
|
9 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
|
called `map(<f>).unwrap_or_default()` on an `Option` value:
crates/crypto/src/keyring/linux/secret_service.rs#L38
warning: called `map(<f>).unwrap_or_default()` on an `Option` value
--> crates/crypto/src/keyring/linux/secret_service.rs:38:5
|
38 | .map(|k| {
| ______________^
39 | | k.search_items(id.as_sec_ser_identifier())
40 | | .ok()
41 | | .map_or(false, |x| !x.is_empty())
42 | | })
43 | | .unwrap_or_default()
| |________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_variant_and
note: the lint level is defined here
--> crates/crypto/src/lib.rs:4:2
|
4 | clippy::pedantic,
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::manual_is_variant_and)]` implied by `#[warn(clippy::pedantic)]`
help: use
|
38 ~ .is_some_and(|k| {
39 ~ k.search_items(id.as_sec_ser_identifier())
40 ~ .ok()
41 ~ .map_or(false, |x| !x.is_empty())
42 ~ })
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L28
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:28:23
|
28 | let mut model_str = first.model.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `first.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L41
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:41:40
|
41 | std::mem::replace(&mut model_str, op.model.clone()),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L54
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:54:40
|
54 | std::mem::replace(&mut model_str, op.model.clone()),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L83
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:83:15
|
83 | ... model: model_str.clone(),
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `model_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
unused `std::result::Result` that must be used:
core/crates/sync/src/ingest.rs#L118
warning: unused `std::result::Result` that must be used
--> core/crates/sync/src/ingest.rs:118:7
|
118 | self.receive_crdt_operation(op).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
118 | let _ = self.receive_crdt_operation(op).await;
| +++++++
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
cypress-videos
Expired
|
1.82 MB |
|