Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media metadata extraction & Thumbnailer rework #2285

Merged
merged 62 commits into from
May 9, 2024
Merged

Media metadata extraction & Thumbnailer rework #2285

merged 62 commits into from
May 9, 2024

Conversation

HeavenVolkoff
Copy link
Member

@HeavenVolkoff HeavenVolkoff commented Apr 5, 2024 •
edited
Loading

  • Extract media (video/audio) metadata with FFmpeg then save it on db and present on front-end
  • Model FFmpeg metadata to database
  • Rename media_data to exif_metadata
  • Integrate FFmpeg metadata extraction into job system and watcher
  • Fix thumbnails generation being broken for portrait videos
  • Greatly improve thumbnailer logic
  • Integrate ffmpeg and media_metadata crate
  • Remove some unused and commented out code
  • Rework, improve logic and rename byte_size to humanize_size

@linear Linear
Copy link

linear bot commented Apr 5, 2024

ENG-949 Collect video duration

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 1:39am
spacedrive-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 1:39am

@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from 06e5aec to 4f10fcd Compare April 10, 2024 06:07
@HeavenVolkoff HeavenVolkoff mentioned this pull request Apr 10, 2024
Closed
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from 4f10fcd to fd6c1d2 Compare April 10, 2024 19:30
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from fd6c1d2 to e2d7a8f Compare April 17, 2024 07:36
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from e2d7a8f to 74b8e96 Compare April 17, 2024 22:16
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from 70e70b4 to 8debe3f Compare April 18, 2024 18:20
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from ef0653f to c2a852c Compare April 19, 2024 05:18
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from 9404e04 to ec677f7 Compare April 20, 2024 00:00
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from 1bad9f1 to 14f5e32 Compare April 20, 2024 10:12
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from fde5356 to cd5cd77 Compare April 22, 2024 17:47
@HeavenVolkoff
small improvements
329651d 
 - Remove some unecessary recursion_limit directive
 - Remove unused app_image releated functions
 - Fix metadata query enabled flag
@HeavenVolkoff HeavenVolkoff marked this pull request as ready for review May 8, 2024 07:52
@HeavenVolkoff HeavenVolkoff requested review from a team as code owners May 8, 2024 07:52
fogodev
fogodev requested changes May 8, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
apps/mobile/src/components/modal/inspector/FileInfoModal.tsx Outdated Show resolved Hide resolved
core/Cargo.toml Outdated Show resolved Hide resolved
core/crates/prisma-helpers/src/lib.rs Show resolved Hide resolved
core/crates/heavy-lifting/src/job_system/job.rs Outdated Show resolved Hide resolved
core/prisma/schema.prisma Show resolved Hide resolved
core/src/lib.rs Show resolved Hide resolved
crates/ffmpeg/Cargo.toml Outdated Show resolved Hide resolved
crates/prisma/src/lib.rs Show resolved Hide resolved
fogodev
fogodev previously approved these changes May 8, 2024
View reviewed changes
@HeavenVolkoff
Implement feedback
6451a78 
 - Update locale keys for all languages
 - Add pnpm command to update all language keys
@HeavenVolkoff HeavenVolkoff force-pushed the eng-949-collect-video-duration branch from ad0cf5a to 6451a78 Compare May 9, 2024 00:06
@HeavenVolkoff HeavenVolkoff requested a review from fogodev May 9, 2024 00:07
fogodev
fogodev approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@fogodev fogodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HeavenVolkoff HeavenVolkoff added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit e797b02 May 9, 2024
12 checks passed
@HeavenVolkoff HeavenVolkoff deleted the eng-949-collect-video-duration branch May 9, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogodev fogodev fogodev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video thumbnails have streaks or rapid zoom jitter
2 participants
@HeavenVolkoff @fogodev