Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-293] Tag assign mode #2462

Merged
merged 42 commits into from
Jun 18, 2024
Merged

[ENG-293] Tag assign mode #2462

merged 42 commits into from
Jun 18, 2024

Conversation

iLynxcat
Copy link
Contributor

@iLynxcat iLynxcat commented May 8, 2024 •
edited
Loading

This PR introduces tag assign mode to Spacedrive.

Changes:

  • Add new tag bar to explorer which shows all tags
    • Click a tag and then press a key 1-9 to assign that tag a hotkey
    • With tag bar open, select files and press a hotkey assigned to a tag to assign that tag to the selected files
    • Click a tag with an assigned hotkey and press Escape to unassign its hotkey
  • Adds Cmd/Ctrl+Alt+T shortcut for opening/closing tag bar
  • Includes localization changes to support new tag bar UI

Closes #2350

@linear Linear
Copy link

linear bot commented May 8, 2024

ENG-293 Tag assign mode

@vercel Vercel
Copy link

vercel bot commented May 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:37am
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:37am

@iLynxcat iLynxcat mentioned this pull request May 21, 2024
Merged
@iLynxcat iLynxcat closed this May 21, 2024
@iLynxcat iLynxcat reopened this May 22, 2024
@iLynxcat iLynxcat marked this pull request as ready for review June 4, 2024 01:50
@iLynxcat iLynxcat requested a review from a team as a code owner June 4, 2024 01:50
myung03
myung03 previously requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@myung03 myung03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool functionality! just some styling issues and visual updates. lmk if you have any questions about any of my suggestions/if you disagree with any of them, would love to learn more about your thought process or explain any confusion :))

interface/locales/ar/common.json Outdated Show resolved Hide resolved
interface/app/$libraryId/Explorer/TopBarOptions.tsx Show resolved Hide resolved
interface/app/$libraryId/Explorer/ExplorerTagBar.tsx Outdated Show resolved Hide resolved
interface/app/$libraryId/Explorer/ExplorerPathBar.tsx Outdated Show resolved Hide resolved
interface/app/$libraryId/Explorer/ExplorerTagBar.tsx Show resolved Hide resolved
interface/app/$libraryId/Explorer/ExplorerTagBar.tsx Show resolved Hide resolved
interface/locales/en/common.json Show resolved Hide resolved
@ameer2468 ameer2468 dismissed myung03’s stale review June 18, 2024 10:50

We will iterate accordingly

@ameer2468 ameer2468 enabled auto-merge June 18, 2024 10:51
@ameer2468 ameer2468 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 0688406 Jun 18, 2024
10 checks passed
@ameer2468 ameer2468 deleted the tag-assign-mode branch June 18, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkubakir utkubakir utkubakir left review comments

@myung03 myung03 myung03 left review comments

@ameer2468 ameer2468 ameer2468 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENG-293] Tag assign mode
5 participants
@iLynxcat @ameer2468 @utkubakir @myung03 @Rocky43007