-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move gitlab runner configuration to a separate terraform module
- Loading branch information
1 parent
0f4cd9b
commit d9418f2
Showing
3 changed files
with
180 additions
and
147 deletions.
There are no files selected for viewing
152 changes: 152 additions & 0 deletions
152
terraform/modules/spack_gitlab/modules/gitlab_runner_configuration/main.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| locals { | ||
| gitlab_domain = "gitlab${var.deployment_name == "prod" ? "" : ".${var.deployment_name}"}.spack.io" | ||
| suffix = var.deployment_name != "prod" ? "-${var.deployment_name}" : "" | ||
|
|
||
| mirror_roles = { | ||
| "pr_binary_mirror" = { | ||
| "role_name_suffix" = "PRBinaryMirror${var.deployment_name == "prod" ? "" : "-${var.deployment_name}"}-${var.deployment_stage}", | ||
| "role_arn_ci_var_name" = "PR_BINARY_MIRROR_ROLE_ARN", | ||
| "conditions" = ["project_path:${data.gitlab_project.spack.path_with_namespace}:ref_type:branch:ref:pr*"], | ||
| }, | ||
| "protected_binary_mirror" = { | ||
| "role_name_suffix" = "ProtectedBinaryMirror${var.deployment_name == "prod" ? "" : "-${var.deployment_name}"}-${var.deployment_stage}", | ||
| "role_arn_ci_var_name" = "PROTECTED_BINARY_MIRROR_ROLE_ARN", | ||
| "conditions" = [ | ||
| "project_path:${var.gitlab_repo}:ref_type:branch:ref:develop", | ||
| "project_path:${var.gitlab_repo}:ref_type:branch:ref:releases/v*", | ||
| "project_path:${var.gitlab_repo}:ref_type:tag:ref:develop-*", | ||
| "project_path:${var.gitlab_repo}:ref_type:tag:ref:v*" | ||
| ], | ||
| } | ||
| } | ||
| } | ||
|
|
||
| data "aws_caller_identity" "current" {} | ||
|
|
||
| data "tls_certificate" "gitlab" { | ||
| url = "https://${local.gitlab_domain}" | ||
| } | ||
|
|
||
| data "aws_s3_bucket" "protected_mirror" { | ||
| bucket = "spack-binaries${local.suffix}" | ||
| } | ||
|
|
||
| data "aws_s3_bucket" "pr_mirror" { | ||
| bucket = "spack-binaries-prs${local.suffix}" | ||
| } | ||
|
|
||
| resource "aws_iam_openid_connect_provider" "gitlab" { | ||
| url = "https://${local.gitlab_domain}" | ||
| client_id_list = keys(local.mirror_roles) | ||
|
|
||
| # Only use the last item in the list, since the first certificate is the root CA, and we don't want to use that. | ||
| thumbprint_list = [data.tls_certificate.gitlab.certificates[length(data.tls_certificate.gitlab.certificates) - 1].sha1_fingerprint] | ||
| } | ||
|
|
||
| data "aws_iam_policy_document" "gitlab_oidc_assume_role" { | ||
| for_each = local.mirror_roles | ||
|
|
||
| statement { | ||
| effect = "Allow" | ||
| actions = ["sts:AssumeRoleWithWebIdentity"] | ||
|
|
||
| principals { | ||
| type = "Federated" | ||
| identifiers = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:oidc-provider/${local.gitlab_domain}"] | ||
| } | ||
|
|
||
| condition { | ||
| test = "StringEquals" | ||
| variable = "${local.gitlab_domain}:aud" | ||
| values = [each.key] | ||
| } | ||
|
|
||
| condition { | ||
| test = "StringLike" | ||
| variable = "${local.gitlab_domain}:sub" | ||
| values = each.value.conditions | ||
| } | ||
| } | ||
| } | ||
|
|
||
| resource "aws_iam_role" "gitlab_runner" { | ||
| for_each = data.aws_iam_policy_document.gitlab_oidc_assume_role | ||
|
|
||
| name = "GitLabRunner${local.mirror_roles[each.key].role_name_suffix}" | ||
| assume_role_policy = each.value.json | ||
| max_session_duration = 3600 * 6 # only allow a max of 6 hours for a session to be active | ||
| } | ||
|
|
||
| data "aws_iam_policy_document" "gitlab_runner" { | ||
| for_each = var.deployment_name != "prod" ? local.mirror_roles : {} | ||
|
|
||
| statement { | ||
| effect = "Allow" | ||
| actions = ["s3:PutObject", "s3:DeleteObject"] | ||
|
|
||
| resources = [ | ||
| each.key == "protected_binary_mirror" ? "${var.protected_binary_bucket_arn}/*" : "${var.var.pr_binary_bucket_arn}/*", | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| resource "aws_iam_policy" "gitlab_runner" { | ||
| for_each = data.aws_iam_policy_document.gitlab_runner | ||
|
|
||
| name = "WriteBinariesTo${local.mirror_roles[each.key].role_name_suffix}" | ||
| description = "Managed by Terraform. IAM Policy that provides access to S3 buckets for binary mirrors." | ||
| policy = each.value.json | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy_attachment" "gitlab_runner" { | ||
| for_each = aws_iam_policy.gitlab_runner | ||
|
|
||
| role = aws_iam_role.gitlab_runner[each.key].name | ||
| policy_arn = each.value.arn | ||
| } | ||
|
|
||
| resource "gitlab_project_variable" "binary_mirror_role_arn" { | ||
| for_each = resource.aws_iam_role.gitlab_runner | ||
|
|
||
| project = data.gitlab_project.spack.id | ||
| key = local.mirror_roles[each.key].role_arn_ci_var_name | ||
| value = each.value.arn | ||
| } | ||
|
|
||
| # pre_build.py needs access to this to request PR prefix scoped permissions | ||
| resource "gitlab_project_variable" "pr_binary_mirror_bucket_arn" { | ||
| project = data.gitlab_project.spack.id | ||
| key = "PR_BINARY_MIRROR_BUCKET_ARN" | ||
| value = var.pr_binary_bucket_arn | ||
| } | ||
|
|
||
| # attachments for the pre-existing hardcoded policies in production | ||
| resource "aws_iam_role_policy_attachment" "legacy_gitlab_runner_pr_binary_mirror" { | ||
| for_each = var.deployment_name == "prod" ? toset(["arn:aws:iam::588562868276:policy/DeleteObjectsFromBucketSpackBinariesPRs", | ||
| "arn:aws:iam::588562868276:policy/PutObjectsInBucketSpackBinariesPRs"]) : [] | ||
|
|
||
| role = aws_iam_role.gitlab_runner["pr_binary_mirror"].name | ||
| policy_arn = each.value | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy_attachment" "legacy_gitlab_runner_protected_binary_mirror" { | ||
| for_each = var.deployment_name == "prod" ? toset(["arn:aws:iam::588562868276:policy/DeleteObjectsFromBucketSpackBinaries", | ||
| "arn:aws:iam::588562868276:policy/PutObjectsInBucketSpackBinaries"]) : [] | ||
|
|
||
| role = aws_iam_role.gitlab_runner["protected_binary_mirror"].name | ||
| policy_arn = each.value | ||
| } | ||
|
|
||
| # Configure retries | ||
| resource "gitlab_project_variable" "retries" { | ||
| for_each = toset([ | ||
| # Enable retries for artifact downloads, source fetching, and cache restoration in CI jobs | ||
| "ARTIFACT_DOWNLOAD_ATTEMPTS", | ||
| "GET_SOURCES_ATTEMPTS", | ||
| "RESTORE_CACHE_ATTEMPTS", | ||
| ]) | ||
|
|
||
| project = data.gitlab_project.spack.id | ||
| key = each.value | ||
| value = "3" | ||
| } |
21 changes: 21 additions & 0 deletions
21
terraform/modules/spack_gitlab/modules/gitlab_runner_configuration/variables.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| variable "deployment_name" { | ||
| type = string | ||
| } | ||
|
|
||
| variable "deployment_stage" { | ||
| type = string | ||
| } | ||
|
|
||
| variable "protected_binary_bucket_arn" { | ||
| description = "The ARN of the S3 bucket that contains protected binaries." | ||
| type = string | ||
| } | ||
|
|
||
| variable "pr_binary_bucket_arn" { | ||
| description = "The ARN of the S3 bucket that contains PR binaries." | ||
| type = string | ||
| } | ||
|
|
||
| variable "gitlab_repo" { | ||
| type = string | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,151 +1,11 @@ | ||
| locals { | ||
| gitlab_domain = "gitlab${var.deployment_name == "prod" ? "" : ".${var.deployment_name}"}.spack.io" | ||
| module "spack_project_runner_configuration" { | ||
| source = "./modules/gitlab_runner_configuration" | ||
|
|
||
| mirror_roles = { | ||
| "pr_binary_mirror" = { | ||
| "role_name_suffix" = "PRBinaryMirror${var.deployment_name == "prod" ? "" : "-${var.deployment_name}"}-${var.deployment_stage}", | ||
| "role_arn_ci_var_name" = "PR_BINARY_MIRROR_ROLE_ARN", | ||
| "conditions" = ["project_path:${data.gitlab_project.spack.path_with_namespace}:ref_type:branch:ref:pr*"], | ||
| }, | ||
| "protected_binary_mirror" = { | ||
| "role_name_suffix" = "ProtectedBinaryMirror${var.deployment_name == "prod" ? "" : "-${var.deployment_name}"}-${var.deployment_stage}", | ||
| "role_arn_ci_var_name" = "PROTECTED_BINARY_MIRROR_ROLE_ARN", | ||
| "conditions" = [ | ||
| "project_path:${data.gitlab_project.spack.path_with_namespace}:ref_type:branch:ref:develop", | ||
| "project_path:${data.gitlab_project.spack.path_with_namespace}:ref_type:branch:ref:releases/v*", | ||
| "project_path:${data.gitlab_project.spack.path_with_namespace}:ref_type:tag:ref:develop-*", | ||
| "project_path:${data.gitlab_project.spack.path_with_namespace}:ref_type:tag:ref:v*" | ||
| ], | ||
| } | ||
| } | ||
| } | ||
|
|
||
| data "aws_caller_identity" "current" {} | ||
|
|
||
| data "tls_certificate" "gitlab" { | ||
| url = "https://${local.gitlab_domain}" | ||
| } | ||
|
|
||
| data "aws_s3_bucket" "protected_mirror" { | ||
| bucket = "spack-binaries${local.suffix}" | ||
| } | ||
|
|
||
| data "aws_s3_bucket" "pr_mirror" { | ||
| bucket = "spack-binaries-prs${local.suffix}" | ||
| } | ||
|
|
||
| resource "aws_iam_openid_connect_provider" "gitlab" { | ||
| url = "https://${local.gitlab_domain}" | ||
| client_id_list = keys(local.mirror_roles) | ||
|
|
||
| # Only use the last item in the list, since the first certificate is the root CA, and we don't want to use that. | ||
| thumbprint_list = [data.tls_certificate.gitlab.certificates[length(data.tls_certificate.gitlab.certificates) - 1].sha1_fingerprint] | ||
| } | ||
|
|
||
| data "aws_iam_policy_document" "gitlab_oidc_assume_role" { | ||
| for_each = local.mirror_roles | ||
|
|
||
| statement { | ||
| effect = "Allow" | ||
| actions = ["sts:AssumeRoleWithWebIdentity"] | ||
|
|
||
| principals { | ||
| type = "Federated" | ||
| identifiers = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:oidc-provider/${local.gitlab_domain}"] | ||
| } | ||
|
|
||
| condition { | ||
| test = "StringEquals" | ||
| variable = "${local.gitlab_domain}:aud" | ||
| values = [each.key] | ||
| } | ||
|
|
||
| condition { | ||
| test = "StringLike" | ||
| variable = "${local.gitlab_domain}:sub" | ||
| values = each.value.conditions | ||
| } | ||
| } | ||
| } | ||
|
|
||
| resource "aws_iam_role" "gitlab_runner" { | ||
| for_each = data.aws_iam_policy_document.gitlab_oidc_assume_role | ||
|
|
||
| name = "GitLabRunner${local.mirror_roles[each.key].role_name_suffix}" | ||
| assume_role_policy = each.value.json | ||
| max_session_duration = 3600 * 6 # only allow a max of 6 hours for a session to be active | ||
| } | ||
|
|
||
| data "aws_iam_policy_document" "gitlab_runner" { | ||
| for_each = var.deployment_name != "prod" ? local.mirror_roles : {} | ||
|
|
||
| statement { | ||
| effect = "Allow" | ||
| actions = ["s3:PutObject", "s3:DeleteObject"] | ||
|
|
||
| resources = [ | ||
| each.key == "protected_binary_mirror" ? "${data.aws_s3_bucket.protected_mirror.arn}/*" : "${data.aws_s3_bucket.pr_mirror.arn}/*", | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| resource "aws_iam_policy" "gitlab_runner" { | ||
| for_each = data.aws_iam_policy_document.gitlab_runner | ||
|
|
||
| name = "WriteBinariesTo${local.mirror_roles[each.key].role_name_suffix}" | ||
| description = "Managed by Terraform. IAM Policy that provides access to S3 buckets for binary mirrors." | ||
| policy = each.value.json | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy_attachment" "gitlab_runner" { | ||
| for_each = aws_iam_policy.gitlab_runner | ||
|
|
||
| role = aws_iam_role.gitlab_runner[each.key].name | ||
| policy_arn = each.value.arn | ||
| } | ||
|
|
||
| resource "gitlab_project_variable" "binary_mirror_role_arn" { | ||
| for_each = resource.aws_iam_role.gitlab_runner | ||
|
|
||
| project = data.gitlab_project.spack.id | ||
| key = local.mirror_roles[each.key].role_arn_ci_var_name | ||
| value = each.value.arn | ||
| } | ||
|
|
||
| # pre_build.py needs access to this to request PR prefix scoped permissions | ||
| resource "gitlab_project_variable" "pr_binary_mirror_bucket_arn" { | ||
| project = data.gitlab_project.spack.id | ||
| key = "PR_BINARY_MIRROR_BUCKET_ARN" | ||
| value = data.aws_s3_bucket.pr_mirror.arn | ||
| } | ||
|
|
||
| # attachments for the pre-existing hardcoded policies in production | ||
| resource "aws_iam_role_policy_attachment" "legacy_gitlab_runner_pr_binary_mirror" { | ||
| for_each = var.deployment_name == "prod" ? toset(["arn:aws:iam::588562868276:policy/DeleteObjectsFromBucketSpackBinariesPRs", | ||
| "arn:aws:iam::588562868276:policy/PutObjectsInBucketSpackBinariesPRs"]) : [] | ||
|
|
||
| role = aws_iam_role.gitlab_runner["pr_binary_mirror"].name | ||
| policy_arn = each.value | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy_attachment" "legacy_gitlab_runner_protected_binary_mirror" { | ||
| for_each = var.deployment_name == "prod" ? toset(["arn:aws:iam::588562868276:policy/DeleteObjectsFromBucketSpackBinaries", | ||
| "arn:aws:iam::588562868276:policy/PutObjectsInBucketSpackBinaries"]) : [] | ||
|
|
||
| role = aws_iam_role.gitlab_runner["protected_binary_mirror"].name | ||
| policy_arn = each.value | ||
| } | ||
| deployment_name = var.deployment_name | ||
| deployment_stage = var.deployment_stage | ||
|
|
||
| # Configure retries | ||
| resource "gitlab_project_variable" "retries" { | ||
| for_each = toset([ | ||
| # Enable retries for artifact downloads, source fetching, and cache restoration in CI jobs | ||
| "ARTIFACT_DOWNLOAD_ATTEMPTS", | ||
| "GET_SOURCES_ATTEMPTS", | ||
| "RESTORE_CACHE_ATTEMPTS", | ||
| ]) | ||
| pr_binary_bucket_arn = data.aws_s3_bucket.pr_mirror.arn | ||
| protected_binary_bucket_arn = data.aws_s3_bucket.protected_mirror.arn | ||
|
|
||
| project = data.gitlab_project.spack.id | ||
| key = each.value | ||
| value = "3" | ||
| gitlab_repo = data.gitlab_project.spack.path_with_namespace | ||
| } |