feat: allow to filter traces for router dispatch event in telemetry module #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scollon42
force-pushed
the
feat-allow-filter-traces-for-router-events
branch
from
cfdaa03
to
b31e91f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a small PR to allow to use the
filter_tracesfunction when tracing router events.I have an application where I need to have 2 endpoint (with their own router / controllers etc.). This is working very well with the endpoint telemetry events since my endpoint use different prefix (ex
[:phoenix, :endpoint, :my-endpoint]) and I can pass theendpoint_telemetry_prefixoptions to catch them properly.But for the router events, since I'm using
SpandexPhoenix.Telemetry.install/1twice (one for each endpoint, with different options), I have duplicated traces.I'm not sure my PR is the right approach, it might be a good idea to allow to pass a new options to handle this but I figured that this would include minimal changes to the codebase and might be prefered for this.
Thanks for the great work on this project 😃 🙌