Merge pull request #266 from sparksuite/demo-site-crash-fix

Refactor pattern of spreading empty arrays to Array.from
sparksuite · Apr 23, 2021 · 09208ac · 09208ac
2 parents 3d7aa9f + 15bb24f
commit 09208ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "react-accessible-dropdown-menu-hook",
-	"version": "2.2.0",
+	"version": "2.2.1",
 	"description": "A simple Hook for creating fully accessible dropdown menus in React",
 	"main": "dist/use-dropdown-menu.js",
 	"types": "dist/use-dropdown-menu.d.ts",

diff --git a/src/use-dropdown-menu.ts b/src/use-dropdown-menu.ts
@@ -36,7 +36,7 @@ export default function useDropdownMenu(itemCount: number): DropdownMenuResponse
 
 	// Initialize refs and update them when the item count changes
 	useEffect(() => {
-		itemRefs.current = [...Array<undefined>(itemCount)].map(() => createRef<HTMLAnchorElement>());
+		itemRefs.current = Array.from({ length: itemCount }, () => createRef<HTMLAnchorElement>());
 	}, [itemCount]);
 
 	// Create type guard
@@ -199,7 +199,7 @@ export default function useDropdownMenu(itemCount: number): DropdownMenuResponse
 		'aria-expanded': isOpen,
 	};
 
-	const itemProps = [...Array<undefined>(itemCount)].map((_ignore, index) => ({
+	const itemProps = Array.from({ length: itemCount }, (_ignore, index) => ({
 		onKeyDown: itemListener,
 		tabIndex: -1,
 		role: 'menuitem',