Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update databases key to use DB_CONNECTION from .env #1714

Closed
wants to merge 1 commit into from

Conversation

maskeynihal
Copy link

Utilizing env('DB_CONNECTION') enables the package to function seamlessly without requiring any adjustments to the backup.php configuration file. It automatically derives the database connection information from the corresponding environment variable, ensuring flexibility in database selection based on the environment.

Utilizing `env('DB_CONNECTION')` enables the package to function seamlessly without requiring any adjustments to the `backup.php` configuration file. It automatically derives the database connection information from the corresponding environment variable, ensuring flexibility in database selection based on the environment.
@freekmurze
Copy link
Member

I think this is a good idea, but it could be considered a breaking change, as there are situations this change will result in a different db being backed up. I'll revisit this when creating a new major version of this package.

@freekmurze freekmurze closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants