account for empty array in notifications config #1880
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported in #1879
Given how the configurations are built,
array_replace_recursive
won't allow to use an empty array as replacement.I am not 100% happy with this solution as it requires to treat
$notifications
array differently from other configs. So feel free to close this and revert the other PR.Anyway I added tests for this changes to ensure it's working as expected, I just don't like to have that "special" treatment of notifications array.
This wouldn't be an issue if instead of an empty array, the way to disable the notification was setting it to
null/false
, but at this moment it would be a breaking change.@freekmurze