Skip to content

Commit

Permalink
Merge pull request #6047 from specify/issue-6040
Browse files Browse the repository at this point in the history
Add id in empty child COJO condition to avoid subview to disappear
  • Loading branch information
CarolineDenis authored Jan 8, 2025
2 parents cfd2dfa + e3f6088 commit 3790744
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
GIT_SHA=${{ github.sha }}
tags: ${{ steps.prep.outputs.tags }}
push: true
retries: 3

- name: Export digest
run: |
Expand Down
8 changes: 4 additions & 4 deletions config/common/common.views.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1984,7 +1984,7 @@
<cell type="field" id="locality" name="childCo.collectingEvent.locality.localityName" uitype="text" readonly="true"/>
</row>
</rows>
<rows condition="childCO=_EMPTY">
<rows condition="childCO.id=_EMPTY">
<row/>
</rows>
</cell>
Expand All @@ -2003,7 +2003,7 @@
<cell type="field" id="typeOfGroup" name="childCog.COGType.Name" uitype="text" readonly="true"/>
</row>
</rows>
<rows condition="childCOG=_EMPTY">
<rows condition="childCOG.id=_EMPTY">
<row/>
</rows>
</cell>
Expand All @@ -2015,7 +2015,7 @@
<cell type="subview" viewname="CollectionObjectMini" id="childCO" name="childCo" uitype="subview" colspan="20"/>
</row>
</rows>
<rows condition="childCo=_EMPTY">
<rows condition="childCO.id=_EMPTY">
<row/>
<!-- Show nothing if no Collection Object Group (COG) or Collection Object (CO) child exists for this COJO record -->
</rows>
Expand All @@ -2028,7 +2028,7 @@
<cell type="subview" viewname="CollectionObjectGroup" id="childCog" name="childCog" colspan="20"/>
</row>
</rows>
<rows condition="childcog=_EMPTY">
<rows condition="childCOG.id=_EMPTY">
<row/>
<!-- Show nothing if no Collection Object Group (COG) or Collection Object (CO) child exists for this COJO record -->
</rows>
Expand Down

0 comments on commit 3790744

Please sign in to comment.