Changes to new dependent resource from Query Combo Box not initially saved

[melton-jason]

Describe the bug
If a dependent relationship is displayed as a Query Combo Box and the "create new resource" (plus) button is clicked, all changes to the dependent resource are lost when the save button is pressed.

issue_demo.mov

This has been an Issue since at least v7.9.6.2.

To Reproduce
Steps to reproduce the behavior:

1. On a form definition for any table, add a to-one dependent relationship as a query combo box
2. Go to the Data Entry form for the table
3. Click on the green plus button to open up the new resource dialog
4. Enter data into any field for the dependent relationship and Save the dependent resource
5. (optional) Click on the pencil icon to open up the dependent form: see that all data has been lost
6. Save the parent record
7. See an "empty" dependent resource has been saved

• Once the dependent resource has been explicitly saved to the parent, any further changes are not lost

Please fill out the following information manually:

• OS: macOS Sonoma (14.3)
• Browser: Chrome 131.0.6778.264 (arm64)
• Specify 7 Version: production - 3790744

Cause of Issue

When the save button is pressed on the dependent resource to save it to the parent, it triggers a set call to set the dependent resource onto the parent

specify7/specifyweb/frontend/js_src/lib/components/QueryComboBox/index.tsx

Lines 600 to 603 in 3790744

	onSaved={(): void => {
	resource?.set(field.name, state.resource as never);
	setState({ type: 'MainState' });
	}}

The set call is fed through the frontend resource API, which eventually triggers a change event

specify7/specifyweb/frontend/js_src/lib/components/DataModel/resourceApi.ts

Line 522 in 3790744

this.trigger(`change:${fieldName}`, this);

One listener of the change event is useResourceValue, which wants to parse and format the newly changed dependent resource. The problem lies in that resource.get still returns the previous value of null or undefined, as the change in the resource api has not yet set the dependent resource on the parent resource.

specify7/specifyweb/frontend/js_src/lib/hooks/useResourceValue.tsx

Lines 239 to 244 in 3790744

	? resourceOn(
	resource,
	`change:${field.name}`,
	(): void => updateValue(resource.get(field.name) as T),
	true
	)

specify7/specifyweb/frontend/js_src/lib/hooks/useResourceValue.tsx

Line 153 in 3790744

resource.set(field.name, formattedValue as never, {