Skip to content

Add exceptions for recursive rendering #6114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Add exceptions for recursive rendering #6114

merged 2 commits into from
Jan 21, 2025

Conversation

sharadsw
Copy link
Contributor

@sharadsw sharadsw commented Jan 17, 2025

Fixes #6067

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Open a COG form
  • Add a child cog
  • Verify the child COG form shows the children field

@CarolineDenis CarolineDenis requested a review from a team January 17, 2025 21:00
@sharadsw sharadsw marked this pull request as ready for review January 17, 2025 21:03
@sharadsw sharadsw added this to the 7.9.11 milestone Jan 17, 2025
Copy link
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the child COG form shows the children field

image

It's there now, also tested adding new children (COG and CO) and I didn't run into issues 👍

@CarolineDenis CarolineDenis requested a review from a team January 17, 2025 21:32
Copy link
Collaborator

@lexiclevenger lexiclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the child COG form shows the children field

Looks good!

I did have a consistent issue in Chrome where the Children subview would disappear after refreshing the page, but it was resolved if I cleared my cache. However, I was unable to recreate it on other devices, so it seems like a personal cache issue.

Screen.Recording.2025-01-17.at.3.56.40.PM.mov

@sharadsw
Copy link
Contributor Author

sharadsw commented Jan 21, 2025

NOTE: Although uncommon, it looks like the issue can occur in other places as well. A generalized solution to this issue doesn't seem very straightforward. I'm gonna go ahead and merge this so COG forms don't stay broken.

I have created a separate issue for creating a generalized solution: #6125

@sharadsw sharadsw merged commit ea36747 into production Jan 21, 2025
12 checks passed
@sharadsw sharadsw deleted the issue-6067 branch January 21, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Subviews hidden when viewing the same form
4 participants