Add modern attachment mimetype icons #6119
Open
+1,536
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by 5c67a02 on branch refs/heads/issue-6118
maxpatiiuk
approved these changes
Jan 20, 2025
CarolineDenis
approved these changes
Jan 22, 2025
pashiav
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
- Upload an attachment with the following file type:
- Thumbnails should be generated for:
- JPEG
- PNG
- TIFF
- GIF
- Mimetype Icons should be displayed for:
- Video
- Audio
- Images (of a different file type)
- PowerPoint
- Word
- XML
- YML
- JSON
- Text
- An unknown mimetype should display generic text icon
- Thumbnails should be generated for:
Looks so much better!
lexiclevenger
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
- Upload an attachment with the following file type:
- Thumbnails should be generated for:
- JPEG
- PNG
- TIFF
- GIF
- Mimetype Icons should be displayed for:
- Video
- Audio
- Images (of a different file type)
- PowerPoint
- Word
- XML
- YML
- JSON
- Text
- An unknown mimetype should display generic text icon
- Thumbnails should be generated for:
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6118
Current Behavior
New Icons
Note that any video or audio attachment will display the appropriate thumbnail. Any presentation file, whether PowerPoint or another format, will show a presentation icon. Unknown MIME types will be represented by a generic text icon.
Checklist
self-explanatory (or properly documented)
Testing instructions
Perform these testing instructions on both
productionand this PR– the behavior should be consistent, except for cases where the icon has changed due to the changes here.