Skip to content

Add a collection pref to display parent cat num if empty #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 28, 2025

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Apr 11, 2025

Fixes #6409

Warning

This PR affects database migrations. See migration testing instructions.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Go to app resources > collection preference
  • Add this snippet:
  "catalogNumberParentInheritance": {
    "behavior": {
      "inheritance": true
    }
  },
  • Save than clear cache
  • Create or open a CO with a cat num
  • Add a child to it without a cat num
  • Save
  • Add a second child with a cat num
  • Save
  • Reload the page
  • Verify that the parent cat num is displayed as placeholder for the empty cat num child (it can take a few seconds to appear)
  • Verify that the cat num you enter for the other one is displayed normally
  • Go to app resource > collection pref
  • Remove the pref
  • Clear cache
  • Go back to your CO
  • verify there is no place holder for the empty cat num child

@CarolineDenis CarolineDenis added this to the 7.10.3 milestone Apr 11, 2025
@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Apr 11, 2025
@CarolineDenis CarolineDenis changed the base branch from production to issue-6407 April 11, 2025 20:41
@CarolineDenis CarolineDenis marked this pull request as ready for review April 15, 2025 14:13
Base automatically changed from issue-6407 to production April 21, 2025 19:07
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that the parent cat num is displayed as placeholder for the empty cat num child
  • Verify that the cat num you enter for the other one is displayed normally
  • verify there is no place holder for the empty cat num child

image

Looks good

@emenslin emenslin requested a review from a team April 25, 2025 17:53
Add parent cat num to empty child cat num if pref true in QB
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that the parent cat num is displayed as placeholder for the empty cat num child (it can take a few seconds to appear)
  • Verify that the cat num you enter for the other one is displayed normally
  • verify there is no place holder for the empty cat num child

Looks good! Working as expected.

@CarolineDenis CarolineDenis merged commit 108eafe into production Apr 28, 2025
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-6409 branch April 28, 2025 18:32
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Parent CO Inheritance: Add a new collection preference to display the parent CO cat num on children
5 participants