Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute resources): suggest recommended limits to CPU and Memory for a Function #243

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Nov 6, 2023

Description & motivation

The Speckle Automate API now allows the compute resources of a Function to be recommended. The Function author can now suggest the maximum CPU and Memory that should reasonably be allocated to a Function when running as part of an Automation. It is intended that the Automation composer has the option to override this, though this is not yet implemented.
The recommended values be changed by publishing a new version of a Function.

Changes:

  • Adds optional parameter speckle_function_recommended_cpu_m and speckle_function_recommended_memory_mi, and associated documentation.
  • Replaces deprecated zod method nonempty with recommended method min(1)

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review November 6, 2023 13:47
@gjedlicska gjedlicska self-requested a review November 6, 2023 13:47
@gjedlicska gjedlicska merged commit 2f4e3cf into main Nov 6, 2023
2 checks passed
@gjedlicska gjedlicska deleted the iain/allow-recommended-cpu-memory branch November 6, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants