Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(receive)!: Fixed issue with collection name conflicts #171

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Sep 12, 2023

Removes any update behaviour of collections which was implemented in a way that is incompatible with having multiple collections with the same name.

closes 170 by adding numeral to name conflicting collections, the same we currently do for name conflicting objects.

We can re-scope a proper updating mode later,
for now, I'm sure most users would prefer all their geometry to receive and link properly over a flawed update mode that was unreliable and misaligned with other connectors.

@JR-Morgan JR-Morgan added bug Something isn't working enhancement New feature or request Converter Related to the blender converter labels Sep 12, 2023
@JR-Morgan JR-Morgan self-assigned this Sep 12, 2023
@JR-Morgan JR-Morgan added this to the 2.16 milestone Sep 12, 2023
@JR-Morgan JR-Morgan merged commit 5ddb2aa into main Sep 12, 2023
@JR-Morgan JR-Morgan deleted the jrm/deps/specklepy216 branch September 12, 2023 09:50
@JR-Morgan JR-Morgan linked an issue Sep 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Converter Related to the blender converter enhancement New feature or request
Projects
No open projects
Status: 🧪 Merged (Test)
Development

Successfully merging this pull request may close these issues.

Receiving collections with identical names is broken
1 participant