fix S3 endpoint variable

specklesystems · Sep 6, 2024 · 2f2dba4 · 2f2dba4
1 parent 2ff40e1
commit 2f2dba4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/preview-service-acceptance.yml b/.github/workflows/preview-service-acceptance.yml
@@ -121,5 +121,5 @@ jobs:
               issue_number: context.issue.number,
               owner: context.repo.owner,
               repo: context.repo.repo,
-              body: '📸 Preview service has generated the following image:<br/><img src="${{ secrets.S3_ENDPOINT }}/${{ env.OUTPUT_FILE_PATH}}"/><br/>'
+              body: '📸 Preview service has generated the following image:<br/><img src="${{ vars.S3_ENDPOINT }}/${{ env.OUTPUT_FILE_PATH}}"/><br/>'
             })
diff --git a/packages/preview-service/tests/acceptance/acceptance.spec.ts b/packages/preview-service/tests/acceptance/acceptance.spec.ts
@@ -105,6 +105,10 @@ describe.sequential('Acceptance', () => {
         const s3Config = getS3Config()
 
         if (s3Config.credentials.accessKeyId && s3Config.credentials.secretAccessKey) {
+          logger.info(
+            { outputFilePath },
+            'S3 credentials provided, saving to S3 at {outputFilePath}'
+          )
           const s3Client = new S3Client(s3Config)
 
           const params: PutObjectCommandInput = {