Matteo/gql

[teocomi]

Adds userSearch and streamSearch

[didimitrie]

Last bit todo: tests!

• for the services, update existing ones if possible
• for the new gql api queries

[didimitrie]

The discussion around max limits & default limits:

• max limits should be implemented everywhere that returns a collection (so we don't get stuff like limit: 1000000 to potentially crash UIs
• default limits: should be a wee bit more conservative, depending on the perceived user-land usage:
  • e.g. commits: we can potentially display a longer list, so it can be higher (50?)
  • e.g. streams: i don't think more than 20-ish? 25? would comfortably fit on a page before you need to switch to either a search or a "next page".

Another note, if we want to be lenient, we could just return the default max limit rather than throw an error, but I guess it's good to inform the dev 👍

[teocomi]

Ok, changed all the defaults to 25. Will keep the error as IMHO it's a better experience than having to open the docs and check why out of my ~123 streams only 100 are showing (happened to me in he past).

[didimitrie]

deal!

[teocomi]

@didimitrie should be all done!

[didimitrie]

done deal. i still itch re some linting stuff, but i'll figure that out later, and then we eslint . --fix. I can't see the test code coverage change, but doesn't matter for now - we'll pump it up later if we find critical paths not being covered

[didimitrie]

Yay then merge away. Feels so formal doing code reviews :D