chore(logging): log all headers but truncate or redact sensitive values #1646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Addresses #1644
Previously we would remove headers which may contain sensitive content. This was frustrating as we could not determine if a header was correctly included, or we could not determine if the value was as expected. While we do not wish to log the entire value it is appropriate in many cases to log the length of the value or a truncated portion of the value.
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References