Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker compose): healthcheck for speckle-server #1651

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jun 23, 2023

Description & motivation

For speckle deployed via Docker Compose, there are conditions where the speckle server container becomes unresponsive but has not yet exited with a non-zero exit code. For example, this issue report #1649

This Pull Request introduces a health check to the pod which will cause non-responsive pods to be automatically restarted after 30s.

This is a workaround for the symptoms (unresponsiveness of the speckle-server pod), and not a fix for the root cause.

Changes:

To-do before merge:

  • test in linux and wsl environments
  • test 1-click docker-compose file

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

- if speckle server pod becomes unresponsive (but has not yet exited with a non-zero exit code), it will be automatically restarted after 30s.
- the docker image is responsible for providing these
@iainsproat iainsproat marked this pull request as ready for review June 29, 2023 12:06
@iainsproat iainsproat requested a review from gjedlicska June 29, 2023 13:36
@gjedlicska gjedlicska merged commit fa36e9e into main Jun 29, 2023
@gjedlicska gjedlicska deleted the 1649-workaround-docker-compose-healthcheck branch June 29, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants