fix(github action): preview service acceptance #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should run on changes to files in directory - fix conflict in pnpm versions
- separate the jobs into a build and a test job - do not run the preview-service via the acceptance test, instead run it via github actions
|
📸 Preview service has generated the following image: |
|
📸 Preview service has generated the following image: |
- something a little broken about this as DO uses buckets as sub-domains, and S3 as part of the path
|
📸 Preview service has generated the following image: |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Fixes the test, so it will run and post a comment.
It will render an empty image for now.
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References