Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): re-enable codecov #3502

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(ci): re-enable codecov #3502

wants to merge 2 commits into from

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Nov 15, 2024

Description & motivation

CodeCov was broken for a while - it wasn't publishing GitHub checks - and we disabled it.

This PR re-enables CodeCov.

The GitHub checks weren't being published because the default behaviour for CodeCov is to wait until all other CI checks are completed before publishing its own. As we include some optional, manually triggered, jobs in CircleCI there will often be jobs that never complete, which blocks CodeCov from publishing. This PR configures CodeCov not to wait until all CI status are complete before publishing.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.05%. Comparing base (8c7ed44) to head (e7144fc).
Report is 1378 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3502      +/-   ##
==========================================
+ Coverage   66.19%   71.05%   +4.85%     
==========================================
  Files         273      364      +91     
  Lines       10724    16117    +5393     
  Branches     1433     2688    +1255     
==========================================
+ Hits         7099    11452    +4353     
- Misses       3173     3766     +593     
- Partials      452      899     +447     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iainsproat iainsproat marked this pull request as ready for review November 18, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant