Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing padding to py-0 from py-1 for default buttons #3800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michalspeckle
Copy link

Description & motivation

Changes:

  • changing padding to py-0 from py-1 for default buttons

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. I checked this out in FE2 briefly, and didn't notice any obvious problems, but we should keep an eye for alignment problems that may come from this.

@michalspeckle
Copy link
Author

I should have mentioned that in the PR description but it fixes the issue we have with label positioning:
https://linear.app/speckle/issue/WEB-2371/something-is-wrong-with-padding-in-the-add-project-button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants