Feat: Setting as pages #3813
Open
Feat: Setting as pages #3813
+1,068
−1,161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikehrn
commented
Jan 15, 2025
| @@ -21,6 +21,71 @@ export const defaultZapierWebhookUrl = | |||
| 'https://hooks.zapier.com/hooks/catch/12120532/2m4okri/' | |||
| export const guideBillingUrl = 'https://speckle.guide/workspaces/billing.html' | |||
|
|
|||
| export const settingsRoutes = { | |||
| user: { | |||
| profile: { | |||
There was a problem hiding this comment.
Both route and name are needed, because they are used in different scenarios (for example checking if a route by name needs SSO access)
Mikehrn
commented
Jan 15, 2025
| @@ -123,3 +123,11 @@ export const workspaceWizardRegionQuery = graphql(` | |||
| } | |||
| } | |||
| `) | |||
|
|
|||
| export const workspaceGetIdBySlugQuery = graphql(` | |||
There was a problem hiding this comment.
Some queries are not possible with workspaceBySlug, as nested properties in some cases need an ID and don't work with slug, so this call is done first to get the id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves away from the settings modal in favor of having them as pages. Some clean-up and bugfixes have been done for the content overall no changes have been made. There is still some room for improvement there, but we can address these in follow-up PRs