Update ifc parser to use new nuget and ability to test #3830
+99
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
reviewed
Jan 15, 2025
| using var process2 = new SerializeProcess( | ||
| new ConsoleProgress(), | ||
| sqlite, | ||
| new DummyServerObjectManager(), |
There was a problem hiding this comment.
why do we create a dummy... class instance in the main process?
There was a problem hiding this comment.
This whole method isn't being used. I probably should move it but it's just for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates server to have the new nuget and latest SDK. Ready for more updates
specklesystems/speckle-sharp-connectors#488