feat(regions): move project branches and commits #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-branches-and-commits
…t-branches-and-commits
|
📸 Preview service has generated an image. |
alemagio
reviewed
Feb 10, 2025
alemagio
reviewed
Feb 10, 2025
alemagio
previously approved these changes
Feb 10, 2025
| .onConflict(Workspaces.withoutTablePrefix.col.id) | ||
| .merge(Workspaces.withoutTablePrefix.cols as (keyof Workspace)[]) | ||
|
|
||
| return workspaceId |
There was a problem hiding this comment.
we should check how workspaces are propagated to the region db and use that to publish the change:
- always update the main db
- update (fake) the main db and use the publish system to update the region
There was a problem hiding this comment.
It appears that we quite literally only care that the workspace id is defined in the regional database for foreign key constraints. Anything user-visible is pulled from the main db record. Simplified this to a copy then ignore on conflict.
|
📸 Preview service has generated an image. |
alemagio
approved these changes
Feb 13, 2025
cdriesler
deleted the
chuck/web-2433-move-project-branches-and-commits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
region2to CI and local test dependencies (so we can test moves between regions, instead of main => region)hooks.ts