Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Dockerfile): remove all ADD statements as cache is missed #3865

Merged
merged 3 commits into from
Jan 22, 2025
Merged

chore(Dockerfile): remove all ADD statements as cache is missed #3865

merged 3 commits into from
Jan 22, 2025

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jan 22, 2025 •
edited
Loading

Description & motivation

Today's breakage of CI highlighted that the Docker cache was being missed. The culprit was identified as the Docker ADD statement.

Changes:

To-do before merge:

Screenshots:

Now hits cache:
Screenshot 2025-01-22 at 12 47 33

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@github-actions GitHub Actions
Copy link
Contributor

📸 Preview service has generated an image.

@github-actions GitHub Actions
Copy link
Contributor

📸 Preview service has generated an image.

@github-actions GitHub Actions
Copy link
Contributor

📸 Preview service has generated an image.

@iainsproat iainsproat marked this pull request as ready for review January 22, 2025 13:06
@iainsproat iainsproat merged commit a1352fe into main Jan 22, 2025
28 of 30 checks passed
@iainsproat iainsproat deleted the iain/dockerfile-remove-add branch January 22, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iainsproat @fabis94