chore(Dockerfile): use COPY --link flag #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hack to only fetch a single commit with depth 1 - cloning the entire repository was subject to cache being missed
- link forces COPY to reuse already built layers in subsequent builds - This is especially important for multi-stage builds where a COPY --from statement would previously get invalidated if any previous commands in the same stage changed, , causing the need to rebuild the intermediate stages again
iainsproat
changed the title
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
fabis94
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Uses Docker
COPY --linkto reduce probability of build cache being invalidated https://docs.docker.com/reference/dockerfile/#benefits-of-using---linkChanges:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References