feat(core): drop the closure table pls #3900
Conversation
|
📸 Preview service has generated an image. |
| db: projectDb | ||
| }) | ||
| }) | ||
| : createObjectsBatchedFactory({ |
There was a problem hiding this comment.
This seems to be the only location that createObjectsBatchedFactory is referenced; can we also remove it in this PR?
| @@ -726,10 +726,6 @@ Generate the environment variables for Speckle server and Speckle objects deploy | |||
| value: {{ .Values.server.asyncRequestContextEnabled | quote }} | |||
| {{- end}} | |||
|
|
|||
| # *** No more closures flag - prevents writing to the closure table *** | |||
| - name: FF_NO_CLOSURE_WRITES | |||
There was a problem hiding this comment.
noClosureWrites should also be removed from the values.yaml file
| } | ||
|
|
||
| export async function down(): Promise<void> { | ||
| // do nothing, we do not care |
There was a problem hiding this comment.
For self-hosters with the flag disabled, we may want to create the empty table again otherwise a reversion is going to cause their code to break entirely.
There was a problem hiding this comment.
i took a look at the migration back, its very complex with a streamId unique setup, I am fine not supporting this down migration. We've been runnign with no closure writes on app for a couple of months now, this should be fine for self hosters.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References