feat(core): drop the closure table pls #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📸 Preview service has generated an image. |
iainsproat
requested changes
Jan 28, 2025
| } | ||
|
|
||
| export async function down(): Promise<void> { | ||
| // do nothing, we do not care |
There was a problem hiding this comment.
For self-hosters with the flag disabled, we may want to create the empty table again otherwise a reversion is going to cause their code to break entirely.
There was a problem hiding this comment.
i took a look at the migration back, its very complex with a streamId unique setup, I am fine not supporting this down migration. We've been runnign with no closure writes on app for a couple of months now, this should be fine for self hosters.
iainsproat
previously approved these changes
Jan 31, 2025
| @@ -84,20 +73,12 @@ export const createObjectFactory = | |||
|
|
|||
| const finalInsertionObject: InsertableSpeckleObject = { | |||
| ...insertionObject, | |||
| totalChildrenCount: closures.length, | |||
| totalChildrenCount, | |||
There was a problem hiding this comment.
Are we using totalChildrenCount or totalChildrenCountByDepth anywhere?
|
📸 Preview service has generated an image. |
iainsproat
approved these changes
Feb 7, 2025
|
📸 Preview service has generated an image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References