Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASD and orthographic projection #3922

Merged
merged 1 commit into from
Feb 4, 2025
Merged

WASD and orthographic projection #3922

merged 1 commit into from
Feb 4, 2025

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Handles https://linear.app/speckle/issue/WEB-2592/wasd-ing-is-not-working-correctly-with-orthographic-projection

  • Pressing WASDQE while in orthographic mode will no longer work. WASD-ing is disabled while in ortho
  • Fixed an issue with toggling to ortho after dropping out of WASD caused by the origin beingvery close to the camera, making the orthographic size to be huge. Now when this happens, we get the minimum distance from the camera to the geometry and use that distance to compute the orthographic size. If no intersection is found, we just take the halfwy between min and max radius

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

- Pressing WASDQE while in orthographic mode will no longer work. WASD-ing is disabled while in ortho
- Fixed an issue with toggling to ortho after dropping out of WASD caused by the origin beingvery close to the camera, making the orthographic size to be huge. Now when this happens, we get the minimum distance from the camera to the geometry and use that distance to compute the orthographic size. If no intersection is found, we just take the halfwy between min and max radius
Copy link

linear bot commented Feb 3, 2025

Copy link
Contributor

github-actions bot commented Feb 3, 2025

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici merged commit b50f1fa into main Feb 4, 2025
28 of 30 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/WEB-2592 branch February 4, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants