Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server & preview-service): apply fix #3921 to all db streams #3929

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

iainsproat
Copy link
Contributor

Description & motivation

Applies #3921 to other locations where database streams are present.

Changes:

  • listen to response event, not request event
  • bind is not required

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat requested a review from gjedlicska February 4, 2025 11:21
@iainsproat iainsproat marked this pull request as ready for review February 4, 2025 11:22
Copy link
Contributor

github-actions bot commented Feb 4, 2025

📸 Preview service has generated an image.

@iainsproat iainsproat merged commit 752041d into main Feb 4, 2025
28 of 30 checks passed
@iainsproat iainsproat deleted the iain/apply-fix-to-all-db-streams branch February 4, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants