Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server/db-streaming): attempt to reduce remaining leaky connections #3936

Closed
wants to merge 1 commit into from

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Feb 5, 2025

Description & motivation

We still have some leaky connections. This is a guess as to what the cause may be.

In this PR we are re-introducing the workaround that knex originally suggested. Although it wasn't necessary to resolve the test that recreated the issue, there is perhaps another root cause (the request closing) that was not recreated by the test.

Mostly a guess, and will observe the impact of this change on actual data once applied.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link
Contributor

github-actions bot commented Feb 5, 2025

📸 Preview service has generated an image.

@iainsproat iainsproat marked this pull request as ready for review February 5, 2025 10:45
@iainsproat
Copy link
Contributor Author

Closed until results of merging #3938 can be observed.

@iainsproat iainsproat closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant