Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Vertex Normals Support #3944

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Added support for custom vertex normals. Moved normal computation from batch level to object level, handling WEB-596 in the process

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

…mal computation from batch level to object level, handling WEB-596 in the process
Copy link

linear bot commented Feb 6, 2025

Copy link
Contributor

github-actions bot commented Feb 6, 2025

📸 Preview service has generated an image.

Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JR-Morgan
Copy link
Member

Here's an example of a rhino SubD geometry that really benefits from this feature

Before:
Rhino-subd

After:
image

And in Rhino (rendered view)
this is the meshified subd, with a similar poly count to what Speckle will send as an example of the bar to reach (which we've done!)
Capture

Sticking more examples here https://testing1.speckle.dev/projects/d7db809737
Including some where the difference is negegable.
curvy 3d subd and breps from Rhino show the most improvement, with no more seams or poorly shaded edges.

I also plan to bring this vertex normals to Blender as in v2 we frequently saw problems with our lack of custom vertex normal support.

@AlexandruPopovici AlexandruPopovici merged commit 647141c into main Feb 12, 2025
42 of 44 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/CNX-1114-Vertex-Normals branch February 12, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants