connectors also need docs

specklesystems · Jul 18, 2024 · 59e5206 · 59e5206
1 parent 7fad22b
commit 59e5206
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Converters/ArcGIS/Speckle.Converters.ArcGIS3/Utils/CRSoffsetRotation.cs b/Converters/ArcGIS/Speckle.Converters.ArcGIS3/Utils/CRSoffsetRotation.cs
@@ -121,7 +121,6 @@ public CRSoffsetRotation(ACG.SpatialReference spatialReference)
   /// <summary>
   /// Initializes a new instance of <see cref="CRSoffsetRotation"/>.
   /// </summary>
-  /// <param name="spatialReference">SpatialReference to apply offsets and rotation to.</param>
   /// <param name="map">Map to read metadata from.</param>
   public CRSoffsetRotation(Map map)
   {

diff --git a/DUI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs b/DUI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs
@@ -74,7 +74,6 @@ private struct RunMethodArgs
   /// Initializes a new instance of the <see cref="BrowserBridge"/> class.
   /// </summary>
   /// <param name="jsonSerializerSettings">The settings to use for JSON serialization and deserialization.</param>
-  /// <param name="loggerFactory">The factory to create a logger for <see cref="BrowserBridge"/>.</param>
   public BrowserBridge(
     JsonSerializerSettings jsonSerializerSettings,
     ILogger<BrowserBridge> logger,

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -12,7 +12,11 @@
   </PropertyGroup>
   <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
     <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+  <PropertyGroup>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <NoWarn>$(NoWarn);1591;1573</NoWarn>
   </PropertyGroup>
 </Project>