DUI3-126 shared files #12
Conversation
- And other simplications, removing dup code etc.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #12 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 161 161
Lines 3155 3155
Branches 340 340
=====================================
Misses 3153 3153
Partials 2 2 ☔ View full report in Codecov by Sentry. |
| @@ -349,7 +343,7 @@ public async Task Send(string modelCardId) | |||
| var result = await unitOfWork.Service | |||
| .Execute( | |||
| mapMembers, | |||
| sendInfo, | |||
| modelCard.GetSendInfo("ArcGIS"), // POC: get host app name from settings? | |||
There was a problem hiding this comment.
okay we will need to resolve this at one point :D (just a comment)
There was a problem hiding this comment.
yes, I'm fairly certain we have a ticket for this, but it was always low prio
| var sendResult = await sendOperation.Service | ||
| .Execute( | ||
| revitObjects, | ||
| sendInfo, | ||
| modelCard.GetSendInfo(_revitSettings.HostSlug.NotNull()), |
There was a problem hiding this comment.
the pattern does seem to be there for revit?
There was a problem hiding this comment.
partly yes, but still this HostSlug in settings depends on old kit classes which we will change it.
| @@ -15,6 +15,7 @@ public static void AddConnectorUtils(this SpeckleContainerBuilder builder) | |||
| // send operation and dependencies | |||
| builder.AddSingleton<CancellationManager>(); | |||
| builder.AddScoped<ReceiveOperation>(); | |||
| builder.AddScoped<AccountService>(); | |||
There was a problem hiding this comment.
from usage, to me it looks like this dude could be better as a singleton?
|
|
||
| namespace Speckle.Connectors.Utils.Operations; | ||
|
|
||
| public class AccountService |
There was a problem hiding this comment.
please add comment on how this class is expected to be injected around, to prevent fuckups like we had in the past when we changed registration and everything went haywire!
There was a problem hiding this comment.
you are god damn right. doing it
didimitrie
deleted the
DUI3-126-Persistent-model-cards-regardless-accounts
branch
ReceiveInforecord as we did before withSendInfoCorresponding PR on UI side -> specklesystems/speckle-server#2459