unpack parameters as Dictionary

Converters/ArcGIS/Speckle.Converters.ArcGIS3/Utils/ArcGISFieldUtils.cs

@@ -132,7 +132,7 @@ public List<FieldDescription> GetFieldsFromSpeckleLayer(VectorLayer target)
     foreach (var baseObj in target)
     {
       // get all members by default, but only Dynamic ones from the basic geometry
-      Dictionary<string, object?> members = new();
+      Dictionary<string, object?> members = baseObj.GetMembers(DynamicBaseMemberType.Dynamic);
       members["Speckle_ID"] = baseObj.id; // to use for unique color values
 
       // leave out until we decide which properties to support on Receive
@@ -191,14 +191,56 @@ List<string> fieldAdded
       // Currently we are not sending any rhino user strings.
       // TODO: add support for attributes of type `Dictionary<string,object?>`
     }
+    else if (field.Value is Dictionary<string, object?> attributeDict)
+    {
+      // only traverse Base if it's Rhino userStrings, or Revit parameter, or Base containing Revit parameters
+      //if (field.Key == "properties")
+      //{
+      foreach (KeyValuePair<string, object?> attributField in attributeDict)
+      {
+        if (
+          attributField.Value is Dictionary<string, object?>
+          || attributField.Key == "applicationId"
+          || attributField.Key == "id"
+        )
+        {
+          KeyValuePair<string, object?> newAttributField = new($"{field.Key}.{attributField.Key}", attributField.Value);
+          Func<Base, object?> functionAdded = x => (function(x) as Dictionary<string, object?>)?[attributField.Key];
+          TraverseAttributes(newAttributField, functionAdded, fieldsAndFunctions, fieldAdded);
+        }
+        else if (attributField.Value is IList attributeDictList)
+        {
+          int count = 0;
+          foreach (var attributeDictField in attributeDictList)
+          {
+            KeyValuePair<string, object?> newAttributeField = new($"{field.Key}[{count}]", attributeDictField);
+            Func<Base, object?> functionAdded = x => (function(x) as List<object?>)?[count];
+            TraverseAttributes(newAttributeField, functionAdded, fieldsAndFunctions, fieldAdded);
+            count += 1;
+          }
+        }
+        else
+        {
+          KeyValuePair<string, object?> newAttributeField =
+            new($"{field.Key}.{attributField.Key}", attributField.Value);
+          Func<Base, object?> functionAdded = x => (function(x) as Dictionary<string, object?>)?[attributField.Key];
+          TryAddField(newAttributeField, functionAdded, fieldsAndFunctions, fieldAdded);
+        }
+      }
+      //}
+      //else
+      //{
+      // for now, ignore all other properties of Dictionnary type
+      //}
+    }
     else if (field.Value is IList attributeList)
     {
       int count = 0;
-      foreach (var attributField in attributeList)
+      foreach (var attributeField in attributeList)
       {
-        KeyValuePair<string, object?> newAttributField = new($"{field.Key}[{count}]", attributField);
+        KeyValuePair<string, object?> newAttributeField = new($"{field.Key}[{count}]", attributeField);
         Func<Base, object?> functionAdded = x => (function(x) as List<object?>)?[count];
-        TraverseAttributes(newAttributField, functionAdded, fieldsAndFunctions, fieldAdded);
+        TraverseAttributes(newAttributeField, functionAdded, fieldsAndFunctions, fieldAdded);
         count += 1;
       }
     }