Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Event aggregator #417

Open
wants to merge 80 commits into
base: dev
Choose a base branch
from
+1,276 −404

Merge branch 'dev' into event-aggregator

f66acbc
Select commit
Loading
Failed to load commit list.
Open

Introduce Event aggregator #417

Merge branch 'dev' into event-aggregator
f66acbc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 1s

8.85% (-0.32%) compared to dbefb1b

View this Pull Request on Codecov

8.85% (-0.32%) compared to dbefb1b

Details

Codecov Report

Attention: Patch coverage is 18.24324% with 242 lines in your changes missing coverage. Please review.

Project coverage is 8.85%. Comparing base (dbefb1b) to head (f66acbc).

Files with missing lines Patch % Lines
...eckle.Connectors.DUI/Eventing/EventSubscription.cs 0.00% 39 Missing ⚠️
...3/Speckle.Connectors.DUI/Eventing/ThreadedEvent.cs 5.88% 32 Missing ⚠️
...UI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs 0.00% 31 Missing ⚠️
DUI3/Speckle.Connectors.DUI/Eventing/EventBase.cs 26.31% 28 Missing ⚠️
...eckle.Connectors.DUI/Eventing/DelegateReference.cs 0.00% 23 Missing ⚠️
...UI3/Speckle.Connectors.DUI/Eventing/PubSubEvent.cs 5.00% 19 Missing ⚠️
...le.Connectors.DUI/Eventing/OneTimeThreadedEvent.cs 0.00% 15 Missing ⚠️
...eckle.Connectors.DUI/Eventing/SubscriptionToken.cs 0.00% 15 Missing ⚠️
....Connectors.DUI/Bridge/TopLevelExceptionHandler.cs 54.16% 10 Missing and 1 partial ⚠️
...I3/Speckle.Connectors.DUI/ContainerRegistration.cs 0.00% 10 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@           Coverage Diff            @@
##             dev    #417      +/-   ##
========================================
- Coverage   9.17%   8.85%   -0.32%     
========================================
  Files        228     240      +12     
  Lines       4296    4505     +209     
  Branches     542     585      +43     
========================================
+ Hits         394     399       +5     
- Misses      3886    4090     +204     
  Partials      16      16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov