Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navisworks and others progress by yielding to UI thread #465

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Dec 30, 2024

Needs to Yield:

  • Navisworks
  • Rhino
  • Tekla
  • ETABS

Doesn't need to Yield:

  • Autocad
  • Revit

ArcGIS is unknown has progress isn't implemented well

Related
https://www.notion.so/speckle/The-Big-Host-App-Threading-Page-14ab78fc7aa6807ca052c6c0869530d2

https://linear.app/speckle/issue/CNX-980/threading-conversion-shows-no-progress

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 9.24%. Comparing base (dcc29f3) to head (63946ba).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...le.Connectors.DUI/Models/Card/ModelCardProgress.cs 0.00% 2 Missing ⚠️
...ckle.Connectors.Common/Operations/SendOperation.cs 0.00% 2 Missing ⚠️
...e.Connectors.Common/Builders/IRootObjectBuilder.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #465      +/-   ##
========================================
- Coverage   9.24%   9.24%   -0.01%     
========================================
  Files        227     227              
  Lines       4260    4262       +2     
  Branches     533     533              
========================================
  Hits         394     394              
- Misses      3850    3852       +2     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review December 30, 2024 10:39
@adamhathcock adamhathcock changed the title Fix Navisworks progress by yielding to UI thread Fix Navisworks and others progress by yielding to UI thread Dec 31, 2024
@adamhathcock adamhathcock enabled auto-merge (squash) December 31, 2024 09:45
@clairekuang clairekuang self-requested a review December 31, 2024 15:03
@adamhathcock adamhathcock merged commit 95b3731 into dev Dec 31, 2024
5 checks passed
@adamhathcock adamhathcock deleted the fix-navis-progress branch December 31, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants