Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhino panels should be treated as if they might have been used before… #467

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

adamhathcock
Copy link
Member

… as Panels.Closed isn't called

Copy link

linear bot commented Jan 6, 2025

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.24%. Comparing base (95b3731) to head (52a7f2d).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #467   +/-   ##
=====================================
  Coverage   9.24%   9.24%           
=====================================
  Files        227     227           
  Lines       4262    4262           
  Branches     533     533           
=====================================
  Hits         394     394           
  Misses      3852    3852           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didimitrie didimitrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rhino_V6yZOPC44Y.mp4

I can seem to still break it, though it is better than before. If you have an idea on how to make it better, let's go - if not, i'll approve

@adamhathcock
Copy link
Member Author

Now only a Rhino 8+ change.

Panels can still be made to be empty like the video but it's better than it was.

@adamhathcock adamhathcock merged commit 3ea5677 into dev Jan 7, 2025
5 checks passed
@adamhathcock adamhathcock deleted the adam/cnx-920-rhino-8-container-is-empty branch January 7, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants