Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for group selection events #471

Merged

Conversation

didimitrie
Copy link
Member

@didimitrie didimitrie commented Jan 7, 2025

Notes: this will now expire a sender model card on group/ungroup events, though it's forcing re-conversion of objects that actually did not change (sigh). Nothing is perfect. solved

Copy link

linear bot commented Jan 7, 2025

this will be necessary as well for layer change events later down the line
@oguzhankoral oguzhankoral merged commit a9850c2 into dev Jan 7, 2025
3 checks passed
@oguzhankoral oguzhankoral deleted the dimitrie/cnx-923-object-tracking-groupingungrouping-in-rhino branch January 7, 2025 16:29
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.16%. Comparing base (64c5503) to head (50e634c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #471   +/-   ##
=====================================
  Coverage   9.16%   9.16%           
=====================================
  Files        228     228           
  Lines       4297    4297           
  Branches     544     544           
=====================================
  Hits         394     394           
  Misses      3887    3887           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants