Dimitrie/cnx 925 Invalidates model cards from layer change events (name, colour) #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #472 +/- ##
=====================================
Coverage 9.16% 9.16%
=====================================
Files 228 228
Lines 4297 4297
Branches 544 544
=====================================
Hits 394 394
Misses 3887 3887
Partials 16 16 ☔ View full report in Codecov by Sentry. |
oguzhankoral
requested changes
Jan 7, 2025
| { | ||
| return; | ||
| } | ||
|
|
||
| // Actual model card invalidation | ||
| string[] objectIdsList = ChangedObjectIds.Keys.ToArray(); | ||
| var changedObjectIdsInGroups = ChangedObjectIdsInGroups.Keys.ToArray(); | ||
| var changedObjectIdsInGroups = ChangedObjectIdsInGroupsOrLayers.Keys.ToArray(); |
There was a problem hiding this comment.
i would rename from changedObjectIdsInGroups to changedObjectIdsInGroupsOrLayers variable too to not confuse ourselves later
|
|
||
| if (isExpired) | ||
| var groupIdIntersection = modelCard.SendFilter.NotNull().SelectedObjectIds.Intersect(changedObjectIdsInGroups); |
There was a problem hiding this comment.
same for groupIdIntersection -> groupOrLayerIdIntersection
oguzhankoral
approved these changes
Jan 7, 2025
didimitrie
deleted the
dimitrie/cnx-925-object-tracking-modifying-layer-color-or-layer-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalidates model cards from layer change events (name, colour). Very fast demo:
Rhino_T3al7UjVI6.mp4