Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(revit): Null check before attempt to override view options #474

Conversation

oguzhankoral
Copy link
Member

I remember @didimitrie you were fixing an issue on forum while implementing OverrideViewOptions function, i believe what i did shouldn't effect what you have done before, but would be nice if you can test that behavior.

BEFORE
image

AFTER
image

Copy link

linear bot commented Jan 8, 2025

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 9.17%. Comparing base (b5b9d06) to head (020f8f3).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...rters.RevitShared/Helpers/DisplayValueExtractor.cs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #474   +/-   ##
=====================================
  Coverage   9.16%   9.17%           
=====================================
  Files        228     228           
  Lines       4297    4296    -1     
  Branches     544     542    -2     
=====================================
  Hits         394     394           
+ Misses      3887    3886    -1     
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzhankoral oguzhankoral merged commit dbefb1b into dev Jan 8, 2025
5 checks passed
@oguzhankoral oguzhankoral deleted the oguzhan/cnx-984-only-one-object-fails-to-convert-from-revit branch January 8, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants