fix(civil): adds top level cogopoint converter #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cogopoints were not properly supported because the full type name of the class is
Autodesk.**Civil**.DatabaseServices.CogoPoint
, but the inheritance isAutodesk.**Autocad**.DatabaseServices.Entity
.This means that the top level civil converter is not registering a converter correctly, since cogopoints inherit from autocad entities not civil entities and we have no top level entity converter in autocad.
This pr fixes the issue by introducing a top level
CogoPoint
converter in civil and converting it as aDataObject
just like all other civil objects. Includes the point name, number, and northing props.sample model: https://latest.speckle.systems/projects/2295cb26a0/models/46f44d5e4e
note @adamhathcock is making a fix for this on the sdk side to register converters based on the full type name. This was previously resulting in wrong exceptions, eg in this case the Civil Entity converter was successfully registered even though it shouldn't have been, because the inherited base type name (
Entity
) exists in both civil and autocad namespaces