Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Event Aggregator with Revit #502

Closed
wants to merge 101 commits into from
Closed

Use Event Aggregator with Revit #502

wants to merge 101 commits into from

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Jan 17, 2025

Requires #505

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 65.00000% with 161 lines in your changes missing coverage. Please review.

Project coverage is 13.76%. Comparing base (db4d2f7) to head (1a22343).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...I3/Speckle.Connectors.DUI/Eventing/SpeckleEvent.cs 26.08% 32 Missing and 2 partials ⚠️
...UI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs 0.00% 31 Missing ⚠️
...I3/Speckle.Connectors.DUI/ContainerRegistration.cs 0.00% 21 Missing ⚠️
...le.Connectors.DUI/Eventing/OneTimeThreadedEvent.cs 67.50% 10 Missing and 3 partials ⚠️
DUI3/Speckle.Connectors.DUI/Eventing/EventBase.cs 64.70% 11 Missing and 1 partial ⚠️
....Connectors.DUI/Bridge/TopLevelExceptionHandler.cs 54.16% 10 Missing and 1 partial ⚠️
...eckle.Connectors.DUI/Eventing/DelegateReference.cs 47.05% 6 Missing and 3 partials ⚠️
...e.Connectors.DUI/Eventing/EventSubscriptionSync.cs 68.42% 5 Missing and 1 partial ⚠️
...eckle.Connectors.DUI/Eventing/SubscriptionToken.cs 70.00% 5 Missing and 1 partial ⚠️
....Connectors.DUI/Eventing/EventSubscriptionAsync.cs 73.68% 5 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff            @@
##             dev     #502      +/-   ##
=========================================
+ Coverage   9.15%   13.76%   +4.61%     
=========================================
  Files        228      241      +13     
  Lines       4306     4672     +366     
  Branches     542      573      +31     
=========================================
+ Hits         394      643     +249     
- Misses      3896     4001     +105     
- Partials      16       28      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as draft January 20, 2025 09:53
@adamhathcock adamhathcock changed the base branch from event-aggregator to async-publish January 20, 2025 14:08
Base automatically changed from async-publish to event-aggregator January 21, 2025 14:12
Base automatically changed from event-aggregator to dev January 21, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant